build: add [profile.dist] required by cargo-dist 0.31.0#75
Merged
Conversation
release-plz was creating the same v{{ version }} tag for both loom-cli
and loom-core, causing "Reference already exists" on the second crate.
Fix: disable git_tag_enable at workspace level, enable it only on
loom-cli (the primary package). loom-core inherits the disabled default.
See: https://release-plz.ieni.dev/docs/extra/single-tag
See: release-plz/release-plz#2292
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cargo-dist 0.31.0 expects a `dist` cargo profile for release builds. Without it, `dist build` fails with "profile `dist` is not defined". Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The v0.2.0 release build failed on all 4 targets with
error: profile 'dist' is not defined. cargo-dist 0.31.0 expects a[profile.dist]in Cargo.toml for release builds.Summary
[profile.dist]inheriting fromreleasewithlto = "thin"for smaller binariesTest Plan
gh workflow run release.yml -f tag=v0.2.0